On Mon, Mar 13, 2017 at 09:28:34AM +0530, SIMRAN SINGHAL wrote: > On Mon, Mar 13, 2017 at 12:03 AM, Alison Schofield <amsfield22@xxxxxxxxx> wrote: > > On Sun, Mar 12, 2017 at 07:02:50PM +0530, simran singhal wrote: > >> The IIO subsystem is redefining iio_dev->mlock to be used by > >> the IIO core only for protecting device operating mode changes. > >> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > >> > >> In this driver, mlock was being used to protect hardware state > >> changes. Replace it with a lock in the devices global data. > >> > >> Fix some coding style issues related to white space also. > >> > >> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx> > > > > Hi Simran, This looks good to me. Let's see what the > > reviewers say. I think the white space stuff is ok, > > since it was right where you were editing. > > alisons > > > Alison, so sending this patch here on outreachy mailing list is fine. > Still confuse :P You are OK. You sent it to everyone suggested in the Task Description. This patch was sent before I posted the Task Description. I'm assuming that since then you've found the posted Task: https://kernelnewbies.org/IIO_tasks Find Coding Task 2 --> "PATCHES need to be sent to all of:" > > >> --- > >> drivers/staging/iio/meter/ade7753.c | 14 ++++++++------ > >> 1 file changed, 8 insertions(+), 6 deletions(-) > >> > >> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c > >> index dfd8b71..ca99d82 100644 > >> --- a/drivers/staging/iio/meter/ade7753.c > >> +++ b/drivers/staging/iio/meter/ade7753.c > >> @@ -81,12 +81,14 @@ > >> * @tx: transmit buffer > >> * @rx: receive buffer > >> * @buf_lock: mutex to protect tx and rx > >> + * @lock: protect sensor state > >> **/ > >> struct ade7753_state { > >> - struct spi_device *us; > >> - struct mutex buf_lock; > >> - u8 tx[ADE7753_MAX_TX] ____cacheline_aligned; > >> - u8 rx[ADE7753_MAX_RX]; > >> + struct spi_device *us; > >> + struct mutex buf_lock; > >> + struct mutex lock; /* protect sensor state */ > >> + u8 tx[ADE7753_MAX_TX] ____cacheline_aligned; > >> + u8 rx[ADE7753_MAX_RX]; > >> }; > >> > >> static int ade7753_spi_write_reg_8(struct device *dev, > >> @@ -484,7 +486,7 @@ static ssize_t ade7753_write_frequency(struct device *dev, > >> if (!val) > >> return -EINVAL; > >> > >> - mutex_lock(&indio_dev->mlock); > >> + mutex_lock(&st->lock); > >> > >> t = 27900 / val; > >> if (t > 0) > >> @@ -505,7 +507,7 @@ static ssize_t ade7753_write_frequency(struct device *dev, > >> ret = ade7753_spi_write_reg_16(dev, ADE7753_MODE, reg); > >> > >> out: > >> - mutex_unlock(&indio_dev->mlock); > >> + mutex_unlock(&st->lock); > >> > >> return ret ? ret : len; > >> } > >> -- > >> 2.7.4 > >> > >> -- > >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > >> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx. > >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170312133250.GA7772%40singhal-Inspiron-5558. > >> For more options, visit https://groups.google.com/d/optout. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
