On Wed, Mar 08, 2017 at 08:54:36AM +0300, Dan Carpenter wrote:
> On Wed, Mar 08, 2017 at 02:36:55PM +1100, Tobin C. Harding wrote:
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> > index 7dc0d99..7ff5345 100644
> > --- a/drivers/staging/ks7010/ks_hostif.c
> > +++ b/drivers/staging/ks7010/ks_hostif.c
> > @@ -318,6 +318,8 @@ int hostif_data_indication_wpa(struct ks_wlan_private *priv, unsigned int auth_t
> > struct mic_failure_t *mic_failure;
> > struct mihcael_mic_t mihcael_mic;
> > union iwreq_data wrqu;
> > + unsigned int key_index = auth_type - 1;
> > + struct wpa_key_t *key = priv->wpa.key[key_index];
> >
> > eth_hdr = (struct ether_hdr *)(priv->rxp);
> > eth_proto = ntohs(eth_hdr->h_proto);
> > @@ -340,7 +342,7 @@ int hostif_data_indication_wpa(struct ks_wlan_private *priv, unsigned int auth_t
> > || (auth_type == TYPE_GMK2
> > && priv->wpa.group_suite ==
> > IW_AUTH_CIPHER_TKIP))
> > - && priv->wpa.key[auth_type - 1].key_len) {
> > + && key.key_len) {
>
> This won't compile. It should be key->key_len.
>
> It's very annoying for me to review compile errors because first of all
> I should never have to. And secondly I have to verify that I'm not just
> misreading the code so I have to leave my email client and it's time
> consuming.
Sloppy work by me, sincere apologies. I'll wait overnight as
previously suggested before resubmitting.
Again, sorry to waste your time.
thanks,
Tobin.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
