Checkpatch emits a bunch of checkpatch warnings, errors and checks when parsing ks_hostif.c and ks_hostif.h The First five patches of this set do general clean up, fixing various warnings along the way. Patch #1 fixes checkpatch warnings/errors relating to misplaced spaces. Patch #2, #3, #4 fix a single checkpatch warning per patch. If necessary a patch may touch both the header and the source file in order to group patches by warning type. Starting at patch #6 effort is applied to cleaning up the function hostif_data_indication(). Patch #6 refactors WPA code into a separate function, this is a cut and paste with additional code added to pass compilation. Patch #7 reduces the level of indentation in the new function. Patch #8 fixes a spelling mistake in various symbols. Patch #9 renames two buffers with more meaningful names. Patch #10 adds two variables to reduce complex access of deeply nested data structures. Patch #11 does whitespace refactor taking advantage of the changes made in the previous patches. Patch #12 removes a line over 80 warning. Series compiles after each commit. Program logic is not modified at any stage of the series. Further testing has not been carried out. Tobin C. Harding (12): staging: ks7010: fix checkpatch whitespace warnings staging: ks7010: fix checkpatch CONSTANT_COMPARISON staging: ks7010: replace C types with kernel types staging: ks7010: fix spelling mistake staging: ks7010: remove unnecessary parenthesis staging: ks7010: factor out WPA code staging: ks7010: reduce level of indentation staging: ks7010: fix spelling of Michael MIC staging: ks7010: add meaningful buffer names staging: ks7010: add variables key, key_index staging: ks7010: refactor, improve code layout staging: ks7010: fix checkpatch line over 80 drivers/staging/ks7010/ks_hostif.c | 448 ++++++++++++++++++----------------- drivers/staging/ks7010/ks_hostif.h | 352 +++++++++++++-------------- drivers/staging/ks7010/michael_mic.c | 8 +- drivers/staging/ks7010/michael_mic.h | 4 +- 4 files changed, 410 insertions(+), 402 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
