On Thu, Feb 16, 2017 at 08:02:58PM +0100, Daniel Perez wrote: > Hi Greg, > I agree with you, that patch looks ugly. I came about this (non) coding style > mistake by running scripts/checkpatch --file --terse on speakup_decp.c . I > re-ran it just now on the unpatched version to check, and I get the following: > > drivers/staging/speakup/speakup_decpc.c:88: WARNING: Block comments should align > the * on each line > > (And a bunch of other warnings regarding other lines) > > I remade the changes and when I run git diff I get the exact same ugly looking > diff text. > > So I'm not sure if its a problem with my version of checkpatch or something > else on my distro (Ubuntu 16.04). > > > Any idea where to look at? checkpatch is just a "hint", it sometimes can not determine things (it's a script). So always use your brain, it should be smarter than a perl script :) Just leave this as-is. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
