Hi Greg, I agree with you, that patch looks ugly. I came about this (non) coding style mistake by running scripts/checkpatch --file --terse on speakup_decp.c . I re-ran it just now on the unpatched version to check, and I get the following: drivers/staging/speakup/speakup_decpc.c:88: WARNING: Block comments should align the * on each line (And a bunch of other warnings regarding other lines) I remade the changes and when I run git diff I get the exact same ugly looking diff text. So I'm not sure if its a problem with my version of checkpatch or something else on my distro (Ubuntu 16.04). Any idea where to look at? Best regards, Daniel On Thu, Feb 16, 2017 at 10:17:54AM -0800, Greg KH wrote: > On Wed, Feb 15, 2017 at 12:02:43PM +0100, Daniel Perez wrote: > > Fixed a coding style issue (block comments misasligned and code indents > > not done with tabs) > > > > Signed-off-by: Daniel Perez <danielperezdeandres@xxxxxxxxx> > > --- > > drivers/staging/speakup/speakup_decpc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c > > index 6bf38e4..ca3fc4d 100644 > > --- a/drivers/staging/speakup/speakup_decpc.c > > +++ b/drivers/staging/speakup/speakup_decpc.c > > @@ -85,8 +85,8 @@ > > #define CTRL_io_priority 0x0c00 /* change i/o priority */ > > #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */ > > #define CTRL_get_lang 0x0e00 /* return bit mask of loaded > > - * languages > > - */ > > + * languages > > + */ > > Ick, does that look correct to you? It does not to me :( > > sorry, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
