Re: [PATCH] Fixed coding style issues of xmit_linux.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 03, 2017 at 07:49:26PM +0530, Abhijit Naik wrote:
> This patch will increase readability of xmit_linux.c file.
> 
> Removed following type of coding style warnings generated for xmit_linux.c,
> 	1. Braces {} are not necessary for single statement blocks
> 	2. Block comments use a trailing */ on a separate line

When you have to list the different things you do in a kernel patch,
that's a huge flag that you need to break this up into multiple patches.

Please do that here.

Also, please fix up your subject to be better suited to this subsystem
and driver, look at the other patches that have been made to this part
of the kernel to get an idea of what you need to do.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux