On Sun, Jan 29, 2017 at 11:56:38PM +0000, James Simmons wrote: > > > On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > > The upstream kernel requires proper structures so > > > convert nearly all the LNet wire protocols typedefs in > > > the LNet core. > > > > Thanks. > > > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too > > I liked to keep that one. Sorry, but no. > The point of WIRE_ATTR isn't to be some abstraction but to label that > struct as something that goes over the wire. This lets people know > that it would break something if you change that structure. Looks like > I need to send a patch that adds a comment explaning the meaning of > WIRE_ATTR. No, please remove it, it's not anything that any other kernel subsystem uses. It's easy to know if you will break something, anything that crosses the user/kernel boundry falls into that category, so if it is in a uapi .h file, that's going to be the case. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
