Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> Just for clarity, when you mean staging code? Are you talking about the
> entire vc04_services driver or are we talking about the vchi_msg_queue
> function?  
> 
> At this point, vc04_services isn't used by anything in the tree at all.
>  So if you want all the unused code deleted, well that sounds to me
> like you are talking about the whole driver.

Yep.  Let's either merge the rest of the code or delete the driver.
What we have now doesn't work.

> 
> I would be more then willing to help upstream the other drivers into
> staging for the RPI that actually uses this driver.  I just don't know
> what the process is for submitting staging drivers.
> 

Just make sure it compiles and send it to the list.


> As for the function, it's still an improvement on the existing which is
> what I through the cleanup process in staging was all about.

I honestly cannot tell one way or the other without looking at the
callers.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux