On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote: > The vchi_msg_queue function which is used by other drivers > to queue a message is difficult to understand and overly > generic. Remove it and replace it with two more specific functions. The vc04_services is missing several drivers. It's in the TODO that we need to merge them. I don't understand why this hasn't happened yet. The entire point of staging is that we merge low quality code as-is so people can clean it up. The vchi_msg_queue() function is only used by the out of tree drivers. The correct thing to do normally would be just to delete it. The cover letter says we delete it, but actually we just make it static and add several more unused functions. I hate that we're mixing __user and kernel pointers and hiding stuff as void pointers. But I can't really review it because it's all out of tree. Let's first merge the out of tree drivers or let's delete the staging code but it's useless to only merge half. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
