Hm... I had never used checkpatch.pl --fix until a few minutes ago. Basically sending a zillion patches is the only way to do anything in the linux-kernel. You're not allowed to break the build, introduce new compile warnings or bugs. We review tons of these patches and introducing bugs is pretty rare actually. The plan would be to do: for i in $(find drivers/staging/vc04_services/ -name \*.c) ; do ./scripts/checkpatch.pl -f --fix-inplace $i ; done Then use git citool. Go through each file and select all the files and highlight all the places where it adds a blank line, right click and select "Stage lines for commit". Write a changelog, hit Sign-off and that's [patch 1/x] "add blank lines". Ignore false postives like when it adds a blank line before DEBUG_INITIALISE(g_state.local). [patch 2/x] remove extra blank lines [patch 3/x] line up parameters Boring work. Then go through manually and fix curly braces positions and other things where checkpatch.pl --fix doesn't work. Turns out that there are over 400 left... Some you can ignore if you feel like, but there are tons that are trivial such as 45 of these: "WARNING: please, no spaces at the start of a line". regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
