This is hard to review because it's moving stuff around, and changing stuff and adding new features. I'll review the v2 patch. One thing I will say is that I have scripts to review when people pull parts of an ioctl into a separate patch. So when you do that, please don't make too many white space changes if you can avoid it. Those confuse my scripts. The other thing is the new callbacks return true on failure and false on success. Stick to negative error codes. If you're going to make a boolean function it should be clear from the name that it's boolean. For example, IS_ERR() is very obviously boolean. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
