No actually, what you did is fine. It all sort of hangs together... You may as well get rid of the ctrl parameter when you get rid of the macro otherwise it just creates a lot of busy work. Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel