Re: [PATCH] staging: sm750fb: Refine the code and remove unused code.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 26, 2016 at 12:03:43AM -0200, Elise Lennion wrote:
> Every call to the function waitNextVerticalSync() used the macro
> primaryWaitVerticalSync(), so the macro was removed and the function
> waitNextVerticalSync() renamed to primary_wait_vertical_sync().
> 
> With this change, an unnecessary 'if' statement was removed together
> with the lines within the 'else' statement, because it was never
> satisfied.
> 
> The modified function was refined to better match the Kernel coding
> style.
> 

Split this into multiple patches:

1) get rid of the macro
2) rename
3) remove the dead code

You could combine 1 & 2, I suppose.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux