Re: [PATCH 2/2] staging: ks7010: fix coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 24, 2016 at 09:50:42PM +0800, Jiong Du wrote:
> Fixes all the checkpath errors/warnings for michael_mic.c:
>     space required before the open brace
>     no space before tabs
>     line over 80 characters
>     space required before the open brace '{'
>     space required after that close brace '}'
>     space prohibited after that open parenthesis '('
>     space prohibited before that close parenthesis ')'
>     Missing a blank line after declarations

That's a lot of different things to be doing all in one patch, please
break this up into smaller patches.

Yes, this is a tiny diff, but really, you should not merge it all into a
single patch :(

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux