On Tue, Sep 20, 2016 at 02:16:12PM +0300, Dan Carpenter wrote: > On Tue, Sep 20, 2016 at 01:05:00PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Sep 20, 2016 at 11:52:19AM +0300, Dan Carpenter wrote: > > > On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > > > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > > > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > > > > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > > > > > was done when porting to the upstream client. > > > > > > > > How did our build testing not catch this? What needs these exports? Is > > > > it any in-kernel code? > > > > > > > > confused, > > > > > > It did catch it... > > > > It did? Works here for me, and I didn't see an error report anywhere... > > > > > James, every patch has to be buildable (bisectable) so the original > > > patch is never going to be merged. > > > > What is the "original" patch here? > > > > [PATCH 112/124] staging: lustre: ptlrpc: remove unnecessary EXPORT_SYMBOL > > kbuild responded to the email that it broke compilation on s360 but I > don't think the breakage is arch specific? Crap, I thought that was some other kbuild failure, my fault for ignoring that. Ok, I'll take half of this patch, if it gets resent... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
