Dear Andy, thanks for your review. On 28/08/2016 14:28, Andy Shevchenko wrote: > On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote: > > Put here few words _why_ you are doing this. I'm doing it because this function is only used inside rtw_recv.c. Which is quite logical, since it's a timer callback: it is passed as the _fn argument to setup_timer(). Sorry for not having explained this in my original commit. I suppose now the best thing is to wait for a few days for more comments, then resubmit with these changes. Do you think it is? > Perhaps, add output of sparse static analyzer. sparse does not detect this issue, and I don't think it could. I found it by code inspection while working on other patches of this series. -- Luca _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
