On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote:
> On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote:
> > This patch fixes a minor checkpatch warnings:
> >
> > "WARNING: Block comments use a trailing */ on a separate line"
> >
> > Signed-off-by: Ming-Chia Chung <Quexint@xxxxxxxxx>
> > ---
> > drivers/staging/rts5208/rtsx.c | 42 ++++++++++++++++++++++++++++--------------
> > 1 file changed, 28 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> > index e992e03..a880411 100644
> > --- a/drivers/staging/rts5208/rtsx.c
> > +++ b/drivers/staging/rts5208/rtsx.c
> > @@ -81,14 +81,16 @@ static int slave_alloc(struct scsi_device *sdev)
> >
> > static int slave_configure(struct scsi_device *sdev)
> > {
> > - /* Scatter-gather buffers (all but the last) must have a length
> > + /*
> > + * Scatter-gather buffers (all but the last) must have a length
>
> The alignment doesnot look correct here. Also in some more places later
> in this patch.
>
> regards
> Sudip
I sent this patch by following docs ([1] and [2]). The style for long
comments needs the begining and ending almost-blank lines. There is no
the begining almost-blank line only for the files in net/ and
drivers/net/.
Please let me know what I misunderstood.
[1]: Linux kernel coding style, ch. 8 Commenting
https://www.kernel.org/doc/Documentation/CodingStyle
[2]: Linus Torvalds on comment styles
https://lkml.org/lkml/2016/7/8/625
regards,
MingChia
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
