On Sat, 2016-06-25 at 14:53 -0500, Larry Finger wrote:
> This driver contains some complicated if ... else if ... else constructions.
> These are replaced by switch statements to improve readability.
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
[]
> @@ -1656,113 +1656,117 @@ static void _rtl8723e_read_adapter_info(struct ieee80211_hw *hw,
> if (rtlhal->oem_id == RT_CID_DEFAULT) {
It'd look nicer too if this were changed to
if (rtlhal->oem_id != RT_CID_DEFAULT)
return;
[]
> switch (rtlefuse->eeprom_oemid) {
[]
> + case 0x1028:
> + switch (rtlefuse->eeprom_smid) {
> + case 0x8194:
> + case 0x8198:
> + case 0x9197 ... 0x9198:
> + rtlhal->oem_id =
> + RT_CID_819X_DELL;
So these could be unindented and on a single line
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
