Re: [PATCH 01/10] rtlwifi: Create common routine to get hardware info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2016-06-25 at 14:53 -0500, Larry Finger wrote:
> All of the rtlwifi family of drivers have a similar routine that acquires
> the hardware info from efuse and initializes a number of variables in the
> driver's private area. A common routine is created for all drivers to use.
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c
[]
> @@ -1243,3 +1244,80 @@ static u8 efuse_calculate_word_cnts(u8 word_en)
>  	return word_cnts;
>  }
>  
> +int rtl_get_hwinfo(struct ieee80211_hw *hw, struct rtl_priv *rtlpriv,
> +		   int max_size, u8 *hwinfo, int *params)
> +{
> +	struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
> +	struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
> +	struct device *dev = &rtlpcipriv->dev.pdev->dev;
> +	u16 eeprom_id;
> +	u16 i, usvalue;
> +
> +	switch (rtlefuse->epromtype) {
> +	case EEPROM_BOOT_EFUSE:
> +		rtl_efuse_shadow_map_update(hw);
> +		break;
> +
> +	case EEPROM_93C46:
> +		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> +			 "RTL819X Not boot from eeprom, check it !!");

Is this EEPROM specific to the 819X series or should
this message use RTL8xxx instead of RTL819X

And this should have a \n at the end of the format.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux