On 23/06/16 02:29, Julian Calaby wrote: > Hi All, > > On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt > <luisbg@xxxxxxxxxxxxxxx> wrote: >> The common format to check if a function returned an error pointer is to >> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors. >> >> Also, if there was an error returning -EINVAL instead of -1 is more >> appropriate. > > These two changes could be argued to be separate changes deserving of > their own patches. > >> Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> > > However if everyone else is ok with that, this is: > > Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx> > > Thanks, > Hi Julian, If you don't mind I will resend as two separate patches and include your Reviewed-by in both. Thanks for the review, Luis _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
