Re: [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 10 Jun 2016, David Kershner wrote:
> Resending due to imcomplete distribution list. 
> 
> This patchset comprises the first 26 patches of the previously-submitted
> patchset (but retracted): 
> 
> 	[PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to
> 			 drivers/virt
> 
> then adds 2 patches to visorinput that:
> 	* fixes a device initialization race condition
> 	* converts a semaphore to a mutex
> 
> As described in the email NAKing the previously-submitted patchset,
> the reason we are re-submitting this now is to make things a bit
> cleaner by separating the fixes we need to make to the code in
> staging from the patchset that actually moves the code out of staging.
> 
> The intent of this patchset is to fix all known outstanding
> issues with code in drivers/staging/unisys/, so that subsequent
> patchsets can move these drivers out of staging.
> 
> tglx: The following patchset fixes issues you raised during your
> code review of visorbus on 5/18, and visorinput on 6/1. 
> 
> Converts visorbus to use a kernel timer for periodic device-specific
> callbacks instead of a workqueue, making the implementation in
> periodic_work.c and periodic_work.h no longer necessary.  These files
> are then deleted.
> 
> The visordriver_callback_lock has been switched to a mutex.
> 
> Several module parameters and structures were removed that were no
> longer being used.

My comments are addressed and the driver looks halfways reasonable now.

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux