tglx: The following patchset fixes issues you raised during your code review of visorbus on 5/18. Converts visorbus to use a kernel timer for periodic device-specific callbacks instead of a workqueue, making the implementation in periodic_work.c and periodic_work.h no longer necessary. These files are then deleted. The visordriver_callback_lock has been switched to a mutex. Several module parameters and structures were removed that were no longer being used. Changes since v2: - Fixed comments raised by Neil Horman regarding return -1 changes - Fixed kernel-doc style comments for visorbus driver, and added kernel-doc documentation for many more functions - Reworked visorbus so we did not need notifier_lock Changes since v1: - Added the patch staging: unisys: visorbus change -1 return values - Added the patch staging: unisys: visorchipset change -1 return value - Added the patch staging: unisys: iovmcall_gnuc.h change -1 return values Bryan Thompson (4): staging: unisys: visorbus: Make visordriver_callback_lock a mutex staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements staging: unisys: visorbus: Remove unused functions staging: unisys: Remove reference to unused STANDALONE_CLIENT David Binder (13): staging: unisys: visorbus: remove unused module parameters staging: unisys: visorbus: remove unused struct staging: unisys: visorbus: modify format string to match argument staging: unisys: visornic: Correct comment spelling mistake staging: unisys: include: Remove thread-related enum members staging: unisys: visorbus: fix commenting in vbusdevinfo.h staging: unisys: visorbus: fix commenting in visorbus_main.c staging: unisys: visorbus: fix visorchannel.c comments staging: unisys: visorbus: Rectify commenting in visorchipset.c staging: unisys: visorbus: Move visorbus-unique functions to private header staging: unisys: visorbus: rectify kerneldoc comment for struct staging: unisys: visorbus: Remove notifier-related code from visorbus staging: unisys: visorbus: Rename function to follow existing convention David Kershner (4): staging: unisys: Move vbushelper.h to visorbus directory include: linux: visorbus: Add visorbus to include/linux directory Documentation: Move visorbus documentation from staging to Documentation/ drivers: Add visorbus to the drivers directory Erik Arfvidson (3): staging: unisys: visorbus change -1 return values staging: unisys: visorchipset change -1 return value staging: unisys: iovmcall_gnuc.h change -1 return values Tim Sell (6): staging: unisys: visorbus: removed unused periodic_test_workqueue staging: unisys: visorinput: remove unnecessary locking staging: unisys: visorbus: use kernel timer instead of workqueue staging: unisys: visorbus: remove periodic_work.h/.c staging: unisys: visorbus: remove unused parameter from function staging: unisys: visorbus: fix visorbus_private.h comments .../ABI/stable/sysfs-bus-visorbus | 0 .../overview.txt => Documentation/visorbus.txt | 0 drivers/staging/unisys/Kconfig | 3 +- drivers/staging/unisys/MAINTAINERS | 2 +- drivers/staging/unisys/Makefile | 1 - drivers/staging/unisys/include/periodic_work.h | 40 - drivers/staging/unisys/include/visorbus.h | 234 ---- drivers/staging/unisys/visorbus/Makefile | 12 - drivers/staging/unisys/visorbus/periodic_work.c | 204 --- drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 213 --- drivers/staging/unisys/visorbus/visorbus_main.c | 1344 ------------------- drivers/staging/unisys/visorbus/visorbus_private.h | 68 - drivers/staging/unisys/visorbus/visorchannel.c | 635 --------- drivers/staging/unisys/visorhba/Makefile | 2 - drivers/staging/unisys/visorhba/visorhba_main.c | 5 +- drivers/staging/unisys/visorinput/Makefile | 2 - drivers/staging/unisys/visorinput/visorinput.c | 63 +- drivers/staging/unisys/visornic/Makefile | 2 - drivers/staging/unisys/visornic/visornic_main.c | 7 +- drivers/virt/Kconfig | 2 + drivers/virt/Makefile | 1 + drivers/{staging/unisys => virt}/visorbus/Kconfig | 0 drivers/virt/visorbus/Makefile | 9 + .../unisys => virt}/visorbus/controlvmchannel.h | 2 +- .../visorbus/controlvmcompletionstatus.h | 0 .../unisys => virt}/visorbus/iovmcall_gnuc.h | 4 +- .../unisys => virt}/visorbus/vbuschannel.h | 3 +- drivers/virt/visorbus/vbusdeviceinfo.h | 234 ++++ .../unisys/include => virt/visorbus}/vbushelper.h | 0 drivers/virt/visorbus/visorbus_main.c | 1403 ++++++++++++++++++++ drivers/virt/visorbus/visorbus_private.h | 65 + drivers/virt/visorbus/visorchannel.c | 516 +++++++ .../unisys => virt}/visorbus/visorchipset.c | 444 +++---- .../unisys => virt}/visorbus/vmcallinterface.h | 5 +- .../include => include/linux/visorbus}/channel.h | 0 .../linux/visorbus}/channel_guid.h | 0 .../linux/visorbus}/diagchannel.h | 0 .../linux/visorbus}/guestlinuxdebug.h | 4 +- .../include => include/linux/visorbus}/iochannel.h | 0 .../include => include/linux/visorbus}/version.h | 0 include/linux/visorbus/visorbus.h | 200 +++ 41 files changed, 2717 insertions(+), 3012 deletions(-) rename drivers/staging/unisys/Documentation/ABI/sysfs-platform-visorchipset => Documentation/ABI/stable/sysfs-bus-visorbus (100%) rename drivers/staging/unisys/Documentation/overview.txt => Documentation/visorbus.txt (100%) delete mode 100644 drivers/staging/unisys/include/periodic_work.h delete mode 100644 drivers/staging/unisys/include/visorbus.h delete mode 100644 drivers/staging/unisys/visorbus/Makefile delete mode 100644 drivers/staging/unisys/visorbus/periodic_work.c delete mode 100644 drivers/staging/unisys/visorbus/vbusdeviceinfo.h delete mode 100644 drivers/staging/unisys/visorbus/visorbus_main.c delete mode 100644 drivers/staging/unisys/visorbus/visorbus_private.h delete mode 100644 drivers/staging/unisys/visorbus/visorchannel.c rename drivers/{staging/unisys => virt}/visorbus/Kconfig (100%) create mode 100644 drivers/virt/visorbus/Makefile rename drivers/{staging/unisys => virt}/visorbus/controlvmchannel.h (99%) rename drivers/{staging/unisys => virt}/visorbus/controlvmcompletionstatus.h (100%) rename drivers/{staging/unisys => virt}/visorbus/iovmcall_gnuc.h (97%) rename drivers/{staging/unisys => virt}/visorbus/vbuschannel.h (99%) create mode 100644 drivers/virt/visorbus/vbusdeviceinfo.h rename drivers/{staging/unisys/include => virt/visorbus}/vbushelper.h (100%) create mode 100644 drivers/virt/visorbus/visorbus_main.c create mode 100644 drivers/virt/visorbus/visorbus_private.h create mode 100644 drivers/virt/visorbus/visorchannel.c rename drivers/{staging/unisys => virt}/visorbus/visorchipset.c (87%) rename drivers/{staging/unisys => virt}/visorbus/vmcallinterface.h (98%) rename {drivers/staging/unisys/include => include/linux/visorbus}/channel.h (100%) rename {drivers/staging/unisys/include => include/linux/visorbus}/channel_guid.h (100%) rename {drivers/staging/unisys/include => include/linux/visorbus}/diagchannel.h (100%) rename {drivers/staging/unisys/include => include/linux/visorbus}/guestlinuxdebug.h (98%) rename {drivers/staging/unisys/include => include/linux/visorbus}/iochannel.h (100%) rename {drivers/staging/unisys/include => include/linux/visorbus}/version.h (100%) create mode 100644 include/linux/visorbus/visorbus.h -- 1.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel