On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote:
On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote:Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test' Signed-off-by: YU Bo <tsu.yubo@xxxxxxxxx> --- drivers/staging/xgifb/vb_setmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 50c8ea4f5ab7..8bf253c224ad 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table, if (pVBInfo->LCDInfo & EnableScalingLCD) tempdx &= (~PanelResInfo); - if (table[i].PANELID == tempdx) { + if (tempdx == table[i].PANELID) {I don't understand why checkpatch is complaining about this one... It seems like a false positive. Maybe it's because .PANELID is a rubbish variable name.
Here, it seems like to notice upper case identifier on the left. https://lkml.org/lkml/diff/2015/8/27/469/1 Best Regards,
regards, dan carpetner
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
