> -----Original Message----- > From: David Kershner [mailto:david.kershner@xxxxxxxxxx] > Sent: Monday, April 18, 2016 10:40 PM > To: gregkh@xxxxxxxxxxxxxxxxxxx; driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx; > *S-Par-Maintainer <SParMaintainer@xxxxxxxxxx> > Cc: Binder, David Anthony <David.Binder@xxxxxxxxxx>; Kershner, David A > <David.Kershner@xxxxxxxxxx> > Subject: [PATCH] staging: unisys: visorbus: initialize variables > > From: David Binder <david.binder@xxxxxxxxxx> > > Initializes previously uninitialized variables that were flagged > as being problematic by Smatch. > > Signed-off-by: David Binder <david.binder@xxxxxxxxxx> > Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx> > --- > drivers/staging/unisys/visorbus/visorchipset.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c > b/drivers/staging/unisys/visorbus/visorchipset.c > index c1b872c..ce2a80e 100644 > --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > @@ -512,7 +512,7 @@ static ssize_t toolaction_show(struct device *dev, > struct device_attribute *attr, > char *buf) > { > - u8 tool_action; > + u8 tool_action = 0; > > visorchannel_read(controlvm_channel, > offsetof(struct spar_controlvm_channel_protocol, > @@ -580,7 +580,7 @@ static ssize_t boottotool_store(struct device *dev, > static ssize_t error_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > - u32 error; > + u32 error = 0; > > visorchannel_read(controlvm_channel, > offsetof(struct spar_controlvm_channel_protocol, > @@ -611,7 +611,7 @@ static ssize_t error_store(struct device *dev, struct > device_attribute *attr, > static ssize_t textid_show(struct device *dev, struct device_attribute *attr, > char *buf) > { > - u32 text_id; > + u32 text_id = 0; > > visorchannel_read > (controlvm_channel, > @@ -643,7 +643,7 @@ static ssize_t textid_store(struct device *dev, struct > device_attribute *attr, > static ssize_t remaining_steps_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - u16 remaining_steps; > + u16 remaining_steps = 0; > > visorchannel_read(controlvm_channel, > offsetof(struct spar_controlvm_channel_protocol, > -- > 1.9.1 Greg, I was wondering what the status of this patch is? Has it been accepted or does it still need some work? Thanks! David Kershner _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
