On Thursday, April 07, 2016 4:24 AM, Ian Abbott wrote:
> On 07/04/16 00:31, H Hartley Sweeten wrote:
>> Tidy up this driver and fix all the checkpatch.pl issues.
>>
>> This series applies after the bug fix patches:
>> staging: comedi: das1800: fix analog input sample munging
>> staging: comedi: das1800: fix analog input number of channels
>> staging: comedi: das1800: fix das-1801st-da boardinfo
>>
>> Patch 28/35 (and possible 29/35) are also bug fixes that I found later.
>> If necessary I can rebase this series so that they are first.
> Thanks! You might need to rebase this series if the prior patch
> "staging: comedi: das1800: fix analog input number of channels" isn't
> applied.
I replied to you about that patch. Let me know it you still prefer to drop it.
> Patch 28/35 and 29/35 apply cleanly to 4.0+ stable series, so you could add:
>
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.0+
>
> to those patches.
>
> The combination of those two patches fixes 99dfc3357e98 ("staging:
> comedi: das1800: remove depends on ISA_DMA_API limitation"). However, I
> don't think you can add a "Fixes:" line for a fix split over two
> patches. Maybe they should be squashed into a single patch.
I squashed them into one patch so the "Fixes:" tag can be added.
> Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
Unless Greg picks them up, when I hear back from you about the
"fix analog input number of channels" patch I will rebase everything
and post a v2 series with all the patches and your Review-by added.
Thanks,
Hartley
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
