On 07/04/16 00:31, H Hartley Sweeten wrote:
Tidy up this driver and fix all the checkpatch.pl issues.
This series applies after the bug fix patches:
staging: comedi: das1800: fix analog input sample munging
staging: comedi: das1800: fix analog input number of channels
staging: comedi: das1800: fix das-1801st-da boardinfo
Patch 28/35 (and possible 29/35) are also bug fixes that I found later.
If neccessary I can rebase this series so that they are first.
H Hartley Sweeten (35):
staging: comedi: das1800: tidy up digital output subdevice init
staging: comedi: das1800: tidy up digital input subdevice init
staging: comedi: das1800: tidy up analog output subdevice init
staging: comedi: das1800: tidy up analog input subdevice init
staging: comedi: das1800: tidy up boardinfo
staging: comedi: das1800: remove 'common' boardinfo member
staging: comedi: das1800: tidy up das1800_ao_insn_write()
staging: comedi: das1800: refactor 'resolution' boardinfo
staging: comedi: das1800: refactor 'do_n_chan' boardinfo
staging: comedi: das1800: refactor 'ao_ability' boardinfo
staging: comedi: das1800: initialize all analog outputs
staging: comedi: das1800: refactor 'ao_n_chan' boardinfo
staging: comedi: das1800: refactor 'range_ai' boardinfo
staging: comedi: das1800: change type of 'ai_speed' boardinfo
staging: comedi: das1800: tidy up das1800_probe()
staging: comedi: das1800: add analog output readback
staging: comedi: das1800: introduce das1800_ai_chanspec_bits()
staging: comedi: das1800: absorb control_c_bits()
staging: comedi: das1800: refactor program_chanlist()
staging: comedi: das1800: use comedi_timeout()
staging: comedi: das1800: absorb control_a_bits()
staging: comedi: das1800: document the spinlock
staging: comedi: das1800: cleanup copyright and comedi comment blocks
staging: comedi: das1800: change type of private data 'fifo_buf'
staging: comedi: das1800: move comment about max conversion speeds
staging: comedi: das1800: remove the private data member comments
staging: comedi: das1800: rename burst_convert_arg()
staging: comedi: das1800: fix das1800_ai_cancel()
staging: comedi: das1800: fix NULL pointer dereference in das1800_ai_setup_dma()
staging: comedi: das1800: remove the function comments
staging: comedi: das1800: fix comments in das1800_ai_cmd()
staging: comedi: das1800: fix comments in das1800_ai_handler()
staging: comedi: das1800: fix lines over 80 characters
staging: comedi: das1800: fix comments about the 'ao' board range
staging: comedi: das1800: update the MODULE_DESCRIPTION
drivers/staging/comedi/drivers/das1800.c | 1191 ++++++++++++++----------------
1 file changed, 545 insertions(+), 646 deletions(-)
Thanks! You might need to rebase this series if the prior patch
"staging: comedi: das1800: fix analog input number of channels" isn't
applied.
Patch 28/35 and 29/35 apply cleanly to 4.0+ stable series, so you could add:
Cc: <stable@xxxxxxxxxxxxxxx> # 4.0+
to those patches.
The combination of those two patches fixes 99dfc3357e98 ("staging:
comedi: das1800: remove depends on ISA_DMA_API limitation"). However, I
don't think you can add a "Fixes:" line for a fix split over two
patches. Maybe they should be squashed into a single patch.
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
