Re: [RFC PATCH v0] Add tw5864 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 11 Mar 2016 09:00:18 +0100
Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> The reason is likely to be the tw5864_queue_setup function which has
> not been updated to handle CREATE_BUFS support correctly. It should
> look like this:
> 
> static int tw5864_queue_setup(struct vb2_queue *q,
> 			      unsigned int *num_buffers,
> 			      unsigned int *num_planes, unsigned int
> sizes[], void *alloc_ctxs[])
> {
> 	struct tw5864_input *dev = vb2_get_drv_priv(q);
> 
> 	if (q->num_buffers + *num_buffers < 12)
> 		*num_buffers = 12 - q->num_buffers;
> 
> 	alloc_ctxs[0] = dev->alloc_ctx;
> 	if (*num_planes)
> 		return sizes[0] < H264_VLC_BUF_SIZE ? -EINVAL : 0;
> 
> 	sizes[0] = H264_VLC_BUF_SIZE;
> 	*num_planes = 1;
> 
> 	return 0;
> }

Thanks for suggestion, but now the failure looks this way:

Streaming ioctls:
        test read/write: OK
                fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY
                fail: v4l2-test-buffers.cpp(703): buf.check(q, last_seq)
                fail: v4l2-test-buffers.cpp(976): captureBufs(node, q, m2m_q, frame_count, false)
        test MMAP: FAIL

Will check that later. If you have any suggestions, I would be very
grateful.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux