Dear Dan, Thank you your great comments. I will be not forget your advice. Please understand that if you have a misunderstanding. Thank you & Best Regards. Leo -----Original Message----- From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] Sent: Monday, February 22, 2016 11:44 PM To: Kim, Leo <Leo.Kim@xxxxxxxxx> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; Park, Chris <Chris.Park@xxxxxxxxx>; Shin, Austin <Austin.Shin@xxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Ferre, Nicolas <Nicolas.FERRE@xxxxxxxxx>; Cho, Tony <Tony.Cho@xxxxxxxxx>; Abozaeid, Adham <Adham.Abozaeid@xxxxxxxxx> Subject: Re: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log On Mon, Feb 22, 2016 at 11:42:42AM +0000, Kim, Leo wrote: > Dear Dan, > > This patch is subject "removes unnecessary wilc_debug print log". I'm fine with you fixing it up in a later patch, but you should not be defending this patch as valid way to do things. The rule is "do one thing at a time", not "do half a thing at a time." In the original code the if statement was required because it was determining when to print, but now it is a confusing unneeded line of code. I'm not asking for an additional unrelated cleanup for something that was already there in the original code. It was this patch which introduced the problem (the stray unneeded line of code). Also I had already asked you to redo this on Feb 19. Part of the reason that we like people to "do one thing per patch" is that people promise they will clean things up in the future but they get distracted and forget. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
