Re: xbox360bb: I want to make my out-of-tree module in-tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 12, 2016 at 11:55:42PM +1100, Michael wrote:
> Hi,
> 
> I've been maintaining an out-of-tree kernel module for the Xbox 360
> "Big Button" controller for about 5 years, called xbox360bb.  It is
> based on some code which was submitted to LKML in 2009, which was
> rejected for vague 'style reasons' at the time.  I am hoping that I
> can get the driver to pass checks for eventual inclusion in the
> mainline kernel.
> 
> The code is at: https://github.com/micolous/xbox360bb
> 
> The device itself uses a protocol similar, yet distinct from the
> normal Xbox 360 controllers.  It is not supported by Microsoft's own
> Xbox controller drivers for Windows.
> 
> The device is a proprietary USB infrared receiver.  There are four
> infrared controllers which are used with a single receiver.  These use
> a subset of the traditional Xbox 360 controller buttons.
> 
> The receiver cannot be used with any other type of infrared device.
> 
> I have a couple of strategies I could pursue in merging this code, but
> I'm not sure which path to take:
> 
> 1. Include it as an extra kernel module. This is good because it can
> live in "extra" for a while until it passes checks.

As the driver seems to grab the same device as an existing kernel
driver, no, that will not work, we don't want/allow drivers for the same
hardware in the kernel tree at the same time as that causes massive
confusion.

> 2. Attempt to merge the code changes into xpad.c.  This is harder as
> it will require that the driver be rewritten.

That seems like the correct thing to do here, sorry.  Best of luck.

Also, try asking this on the linux-input mailing list, I don't think
that the current xpad.c driver is the best thing to emulate, why not tie
into the "proper" apis instead?

good luck,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux