Julian Calaby <julian.calaby@xxxxxxxxx> writes: > Hi Bhaktipriya, > > On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> wrote: >> Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx> writes: >> If you insist on pushing this rather unncessary change, please do it >> properly, and remove the blank line before the return statement as well. > > As Jes said, you need to remove the blank lines before the returns > too. checkpatch should have picked this up, you did run the patch > through checkpatch before you sent it, right? > > Jes, > > I know you have strong feelings on coding style, but there are a lot > of people out there who see deviations from the standard as bugs to be > fixed, so stuff like this isn't going to stop until it matches the > coding style document's spec. Julian, rtl8723au is pretty dead development wise, so I don't care too much. checkpatch is broken and has effectively turned into a policing tool for a few people who wish to apply their narrow view onto everyone else. I'll continue top reject broken patches to my code pushed out under those rules. Maybe it's time to introduce checkpatchconsideredharmful.com Jes _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
