On Jan 4, 2016, at 12:45 PM, Simmons, James A. wrote:
>> From: Oleg Drokin <green@xxxxxxxxxxxxxx>
>>
>> IOC_LIBCFS_DEBUG_PEER was added back in the stone ages to print debug
>> statistics on a peer when peer timeout happens.
>> Redo it properly as a separate LNet API call,
>> also get rid of "ioctl" forwarding into the underlying LNDs,
>> since no current LNDs implement this function anymore.
> ..
>> diff --git a/drivers/staging/lustre/include/linux/lnet/api.h b/drivers/staging/lustre/include/linux/lnet/api.h
>> index 75285fd..fa5fad3 100644
>> --- a/drivers/staging/lustre/include/linux/lnet/api.h
>> +++ b/drivers/staging/lustre/include/linux/lnet/api.h
>> @@ -197,6 +197,7 @@ int LNetGet(lnet_nid_t
>> int LNetSetLazyPortal(int portal);
>> int LNetClearLazyPortal(int portal);
>> int LNetCtl(unsigned int cmd, void *arg);
>> +void LNetDebugPeer(lnet_process_id_t id);
>
> We don't need this one line camel case wrapper.
>
>>
>> /** @} lnet_misc */
>>
> ...
>> @@ -1436,6 +1406,12 @@ LNetCtl(unsigned int cmd, void *arg)
>> }
>> EXPORT_SYMBOL(LNetCtl);
>>
>> +void LNetDebugPeer(lnet_process_id_t id)
>> +{
>> + lnet_debug_peer(id.nid);
>> +}
>> +EXPORT_SYMBOL(LNetDebugPeer);
>
> Lets just use lnet_debug_peer directly.
It's not exported and this is not how we export functionality out of the LNet.
The way I did it is the way LNet api is exposed. Why break the custom all of a sudden and
replace one hack with another?
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
