RE: [PATCH 02/29] staging/lustre/lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>From: Oleg Drokin <green@xxxxxxxxxxxxxx>
>
>IOC_LIBCFS_DEBUG_PEER was added back in the stone ages to print debug
>statistics on a peer when peer timeout happens.
>Redo it properly as a separate LNet API call,
>also get rid of "ioctl" forwarding into the underlying LNDs,
>since no current LNDs implement this function anymore.
..
>diff --git a/drivers/staging/lustre/include/linux/lnet/api.h b/drivers/staging/lustre/include/linux/lnet/api.h
>index 75285fd..fa5fad3 100644
>--- a/drivers/staging/lustre/include/linux/lnet/api.h
>+++ b/drivers/staging/lustre/include/linux/lnet/api.h
>@@ -197,6 +197,7 @@ int LNetGet(lnet_nid_t	      
> int LNetSetLazyPortal(int portal);
> int LNetClearLazyPortal(int portal);
> int LNetCtl(unsigned int cmd, void *arg);
>+void LNetDebugPeer(lnet_process_id_t id);

We don't need this one line camel case wrapper.

> 
> /** @} lnet_misc */
>
 ...
>@@ -1436,6 +1406,12 @@ LNetCtl(unsigned int cmd, void *arg)
> }
> EXPORT_SYMBOL(LNetCtl);
 >
>+void LNetDebugPeer(lnet_process_id_t id)
>+{
>+	lnet_debug_peer(id.nid);
>+}
>+EXPORT_SYMBOL(LNetDebugPeer);

Lets just use lnet_debug_peer directly.

>+
> /**
>  * Retrieve the lnet_process_id_t ID of LNet interface at \a index. Note that
>  * all interfaces share a same PID, as requested by LNetNIInit().

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux