Re: [PATCH] staging: speakup: (coding sytle) remove unnecessary space after a cast

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.4-rc1 next-20151119]

url:    https://github.com/0day-ci/linux/commits/Christian-Colic/staging-speakup-coding-sytle-remove-unnecessary-space-after-a-cast/20151120-012835
config: i386-randconfig-a0-201546 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/staging/speakup/devsynth.c: In function 'speakup_file_write':
>> drivers/staging/speakup/devsynth.c:37:9: warning: 'bytes' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return (ssize_t)bytes;
            ^

vim +/bytes +37 drivers/staging/speakup/devsynth.c

    21		size_t bytes;
    22		unsigned long flags;
    23		u_char buf[256];
    24	
    25		if (!synth)
    26			return -ENODEV;
    27		while (count > 0) {
    28			bytes = min(count, sizeof(buf));
    29			if (copy_from_user(buf, ptr, bytes))
    30				return -EFAULT;
    31			count -= bytes;
    32			ptr += bytes;
    33			spin_lock_irqsave(&speakup_info.spinlock, flags);
    34			synth_write(buf, bytes);
    35			spin_unlock_irqrestore(&speakup_info.spinlock, flags);
    36		}
  > 37		return (ssize_t)bytes;
    38	}
    39	
    40	static ssize_t speakup_file_read(struct file *fp, char __user *buf,
    41					 size_t nbytes, loff_t *ppos)
    42	{
    43		return 0;
    44	}
    45	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux