RE: [PATCH] Staging: comedi: comedi.h Fixed multiple coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, November 19, 2015 3:21 AM, Ian Abbott wrote:
> On 18/11/15 19:23, Daniel H. Hemmingsen wrote:
>> Fixed multiple comments and spacing coding style issues.
>>
>> Signed-off-by: Daniel H. Hemmingsen <dhh.kernel@xxxxxxxxx>
>> ---
>>   drivers/staging/comedi/comedi.h | 307 +++++++++++++++++++++++-----------------
>>   1 file changed, 177 insertions(+), 130 deletions(-)
>
> Thanks!  Although you missed a couple of wrongly formatted comments for 
> INSN_CONFIG_GET_HARDWARE_BUFFER_SIZE and INSN_CONFIG_PWM_SET_H_BRIDGE, 
> it's a great improvement.
>
> Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

There are still a couple block comments that don't follow the kernel
CodingStyle and some minor alignment issues but these can be fixed
later. Overall it looks a lot better and removes most of the checkpatch.pl
issues.

Thanks for the patch.

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux