Re: [PATCH 07/14] staging: unisys: Fix guestlinuxdebug.h comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 17, 2015 at 01:34:54PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson <erik.arfvidson@xxxxxxxxxx>
> 
> This patch simply cleans up all checkpatch warnings and fixes
> styling
> 
> Signed-off-by: Erik Arfvidson <erik.arfvidson@xxxxxxxxxx>
> Signed-off-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx>
> ---
>  drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/guestlinuxdebug.h b/drivers/staging/unisys/include/guestlinuxdebug.h
> index 82ee565..c1d515f 100644
> --- a/drivers/staging/unisys/include/guestlinuxdebug.h
> +++ b/drivers/staging/unisys/include/guestlinuxdebug.h
> @@ -17,9 +17,10 @@
>  #define __GUESTLINUXDEBUG_H__
>  
>  /*
> -* This file contains supporting interface for "vmcallinterface.h", particularly
> -* regarding adding additional structure and functionality to linux
> -* ISSUE_IO_VMCALL_POSTCODE_SEVERITY */
> + * This file contains supporting interface for "vmcallinterface.h", particularly
> + * regarding adding additional structure and functionality to linux
> + * ISSUE_IO_VMCALL_POSTCODE_SEVERITY
> + */
>  
>  /******* INFO ON ISSUE_POSTCODE_LINUX() BELOW *******/
>  enum driver_pc {		/* POSTCODE driver identifier tuples */
> @@ -133,9 +134,9 @@ enum event_pc {			/* POSTCODE event identifier tuples */
>  
>  #define POSTCODE_SEVERITY_ERR DIAG_SEVERITY_ERR
>  #define POSTCODE_SEVERITY_WARNING DIAG_SEVERITY_WARNING
> -#define POSTCODE_SEVERITY_INFO DIAG_SEVERITY_PRINT	/* TODO-> Info currently
> -							 * doesn't show, so we
> -							 * set info=warning */
> +#define POSTCODE_SEVERITY_INFO DIAG_SEVERITY_PRINT
> +/* TODO-> Info currently doesn't show, so we set info=warning */

Comment should go on top of the #define, not below it.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux