Greg,
On Fri, Oct 16, 2015 at 10:04:57PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 13, 2015 at 11:27:54AM +0530, Sudip Mukherjee wrote:
> > > > >
> > > > > The code from ddk750_dvi and ddk750_sii164 is never called from the rest
> > > > > of the driver, the USE_DVICHIP is defined and used only by ddk750_dvi
> > > > > and ddk750_sii164 themself, and USE_HW_I2C is used only by
> > > > > ddk750_sii164.
> > > >
> > > > Hmmm, I checked up the old code (v4.2) and the current one in staging.
> > > > sii164 will be initialized and would have been used by dviInit() and
> > > > dviInit() was being used by ddk750_initDVIDisp(). But ddk750_initDVIDisp()
> > > > has been removed by 86b5f4ed3525 ("staging: sm750fb: remove unused
> > > > ddk750_initDVIDisp function").
> > > > And the call to ddk750_initDVIDisp() was disabled by #ifdef 0 and that
> > > > was removed by 1282bade3b8e ("staging: sm750fb: remove dead code").
> > > >
> > > > I am not sure what should be done in this situation. Greg, can you
> > > > please suggest something... I think we can add another config option for
> > > > SM750LE and reintroduce ddk750_initDVIDisp() (with a better name) and
> > > > enable building them if CONFIG_SM750LE is enabled.
> > >
> > > Ick, why? More config options is never the right answer...
> >
> > Then maybe the best option will be read the hardware ID from the
> > registers and based on that decide the execution flow. But the only (and
> > the main) problem is that I don't have SM750LE hardware, I only have the
> > SM750 normal hardware and so I will not be able to test the code on
> > SM750LE.
> > And besides, before investing more time to develop this code, what is
> > the future of this driver? Tomi is not that interested to have one more
> > fbdev driver. In that case, should I continue to develop this code for
> > moving out of staging or concentrate on having atleast a basic drm
> > driver to start with?
>
> I think it's not a problem to add more fb drivers, but maybe it should
> stay in staging for a while until Tomi comes to his senses :)
Assuiming sm750fb remains an fb driver, what do you suggest regarding
the DVI controller initialization?
Reintroduce renamed ddk750_initDVIDisp and call it whenever SM750LE
revision of the chip is detected?
Or drop the dead code and see how we re-add it once the driver is in
better shape?
> thanks,
>
> greg k-h
--
Sincerely yours,
Mike.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
