Hi Sudip, On Thu, Oct 08, 2015 at 11:46:28AM +0530, Sudip Mukherjee wrote: > On Tue, Oct 06, 2015 at 04:49:13PM +0100, Mike Rapoport wrote: > > Currently the sii164 DVI controller support is unused anywhere in the rest of > > the driver, and, anyway it does not belong to framebuffer device driver. > > These patches remove the sii164 DVI controller support. > I am not sure if we can remove sii164. Sil164 has two configuration > method. One is from i2c R/W and the other is hardware gpio setting. > > Generally, we use hardware GPIO setting. So we don't need any driver for > sil164. And that is why you see it is unused here. > > But SM750LE will always require swi2c for its dvi chip. And SM750LE is a > special version of the hardware which only Huawei uses. > > And if i remember correctly sii164 code will be used if USE_DVICHIP and > USE_HW_I2C are not defined. The code from ddk750_dvi and ddk750_sii164 is never called from the rest of the driver, the USE_DVICHIP is defined and used only by ddk750_dvi and ddk750_sii164 themself, and USE_HW_I2C is used only by ddk750_sii164. As I've mentioned earlier (1), sm750 has several sub-devices and idealy we should have an MFD driver and sub-devices drivers. Than I2C controller and GPIO controller would be enabled by their own drivers and the DVI controller would be configured as a device on the I2C bus. Anyway, if we are to keep the DVI controller related code, there should be something that actually uses that code in the sm750 driver. As for selection whether to use DVI controller and how it will be accessed, it should be at least a build option rather then several defines that are set once and forever. [1] http://www.spinics.net/lists/linux-driver-devel/msg72426.html > TODO file lists removal of USE_HW_I2C and USE_DVICHIP as at that time I > planned to remove support of SM750LE but Greg suggested to keep it > (https://lkml.org/lkml/2015/3/19/353). > > regards > sudip -- Sincerely yours, Mike. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
