On Fri, Oct 2, 2015 at 3:06 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Fri, Oct 02, 2015 at 07:56:28AM +0900, Chaehyun Lim wrote: >> On Fri, Oct 2, 2015 at 12:40 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: >> > On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote: >> >> This patch replaces int8_t with s8 that is a preferred type. >> >> >> > >> > It would be better to just use int. >> >> I always appreciate your comment. I've sent a patch before after >> changing by int, but it was rejected. > > Probably your changelog was bad. Using s8 is hopefully a sign that you > are doing something very hardware specific. In this case, it is just a > index. > > Write the changelog. "The int8_t should just be int. It's used as an > index into an array or -1 for not found." > Thank you for your comment. I'll make v2 patch after applying your suggestion. regards Chaehyun Lim > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
