Re: [PATCH staging 2/3] wilc1000 : Remove leftover comment delimiters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 28, 2015 at 11:25:04PM -0700, Anish Bhatt wrote:
> On Mon, Sep 28, 2015 at 5:42 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Fri, Sep 25, 2015 at 12:45:16AM -0700, Anish Bhatt wrote:
> >> Remove leftover comment delimiters that were only partially removed
> >> in a previous cleanup.
> >
> > You also changed code formatting, which isn't ok to do in the same
> > patch, please break it up into different patches.
> >
> > thanks,
> >
> > greg k-h
> 
> If I don't add the line break though, checkpatch will complain as the line is
> far longer than 80 characters. Are checkpatch warnings preferred over
> adding a new line while making changes ?

Do only one logical thing at a time please.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux