On Fri, Sep 25, 2015 at 08:25:32AM +0100, Salah Triki wrote: > dgnc_driver_pollrate_store needs to take a lock before modifying the > shared variable dgnc_poll_tick. > Nope. This patch is useless. Patch v3 was correct, you just need to fix the changelog. Reads of dgnc_poll_tick are protected by xxxxxx spinlock, but the write to dgnc_poll_tick is not. It could theoretically race. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel