Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote:
> 
> 
> On 2015년 09월 21일 11:01, Greg KH wrote:
> >On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote:
> >>This patch removes function declaration of WILC_WFI_frame_register in
> >>linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file.
> >>
> >>The compilation warning occurs because it is assigned to incorrect
> >>pointer type of second parameter of WILC_WFI_frame_register.
> >>It is assigned with struct wireless_dev pointer type.
> >How was this code ever even working properly if the wrong pointer was
> >being passed into it?
> >
> >Tony, what is going on here, is this code just never called?  If so, can
> >we just delete the whole function?
> >
> >thanks,
> >
> >greg k-h
> 
> This file with linux_wlan.c file is being fully changed, but at this time, the second parameter which passed as
> net_device pointer instead of wireless_dev incorrectly is never being used inside the WILC_WFI_frame_register().
> That's why no problem is found yet.

Then we should just delte the parameter entirely, no need to pass
something into a function that is never used.

Please, someone do that instead.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux