On 2015년 09월 21일 11:01, Greg KH wrote:
On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote:
This patch removes function declaration of WILC_WFI_frame_register in
linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file.
The compilation warning occurs because it is assigned to incorrect
pointer type of second parameter of WILC_WFI_frame_register.
It is assigned with struct wireless_dev pointer type.
How was this code ever even working properly if the wrong pointer was
being passed into it?
Tony, what is going on here, is this code just never called? If so, can
we just delete the whole function?
thanks,
greg k-h
This file with linux_wlan.c file is being fully changed, but at this time, the second parameter which passed as
net_device pointer instead of wireless_dev incorrectly is never being used inside the WILC_WFI_frame_register().
That's why no problem is found yet.
As of the patch which Chaehyun Lim made, the second parameter, nic->wilc_netdev should be replaced by nic->wilc_netdev->ieee80211_ptr.
Thanks,
Tony.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
