On Sat, Sep 12, 2015 at 02:04:43AM -0700, Anish Bhatt wrote:
> On Fri, Sep 11, 2015 at 7:42 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, Sep 09, 2015 at 03:57:09PM -0700, Anish Bhatt wrote:
> >> The BIT() macro is already defined in bitops.h, remove duplicate
> >> definitions. Users of BIT() macro are expecting unsigned int/u32, so
> >> add typecasts where this creates a build warning.
> >>
> >> Signed-off-by: Anish Bhatt <anish@xxxxxxxxxxx>
> >> ---
> >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 7 +++++--
> >> drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 ++++--
> >> drivers/staging/rtl8188eu/include/rtl8188e_spec.h | 4 ----
> >> drivers/staging/rtl8188eu/include/wifi.h | 7 -------
> >> 4 files changed, 9 insertions(+), 15 deletions(-)
> >>
> >> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> >> index 5dae7de..dd82018 100644
> >> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> >> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> >> @@ -4177,10 +4177,13 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
> >>
> >> RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_,
> >> ("+mgt_dispatcher: type(0x%x) subtype(0x%x)\n",
> >> - GetFrameType(pframe), GetFrameSubType(pframe)));
> >> + (unsigned int)GetFrameType(pframe),
> >> + (unsigned int)GetFrameSubType(pframe)));
> >
> > I don't understand why you are adding these typecasts, you aren't
> > changing anything that requires this, right?
>
> BIT() is defined in bitops as (1UL << x). This causes compiler warnings with
> the %x format specifier used in the RT_TRACE messages, where previously
> rtl8188eu simply had (1 << x), hence the typecasts.
Ok, that makes sense. Can you please resend this, it's now out of my
queue.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
