On Mon, Sep 14, 2015 at 12:24:29PM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_frame_register with mgmt_frame_register to > avoid CamelCase. > > Signed-off-by: Chaehyun Lim <chaehyun.lim@xxxxxxxxx> > --- > V3: remove "wilc_" prefix > > drivers/staging/wilc1000/linux_wlan.c | 12 ++++++------ > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++----- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c > index 63f44f8..5576e1c 100644 > --- a/drivers/staging/wilc1000/linux_wlan.c > +++ b/drivers/staging/wilc1000/linux_wlan.c > @@ -1618,8 +1618,8 @@ int mac_init_fn(struct net_device *ndev) > return 0; > } > > -void WILC_WFI_frame_register(struct wiphy *wiphy, struct net_device *dev, > - u16 frame_type, bool reg); > +void mgmt_frame_register(struct wiphy *wiphy, struct net_device *dev, > + u16 frame_type, bool reg); This should be in a .h file, as it's a global variable. And because it's global, it needs to keep a wilc_ prefix, right? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel