On 08/18/15 10:00, Doug Ledford wrote: > >> On Aug 18, 2015, at 9:50 AM, Greg KH <greg@xxxxxxxxx> wrote: >> >> On Tue, Aug 18, 2015 at 04:29:50PM +0000, Marciniszyn, Mike wrote: >>>> Subject: Re: [PATCH] Kconfig: add temporary PCI dependency >>>> >>>> On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote: >>>>> The move from infiniband to staging requires a temporary PCI >>>>> dependency to fix 0-day build issues. The >>>>> drivers/infiniband/hw/Kconfig gratuitously added it for all drivers. >>>>> >>>>> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx> >>>>> --- >>>>> drivers/staging/hfi1/Kconfig | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> Why are these drivers not in drivers/staging/infiniband/ ? Why do they all >>>> need their own drivers/staging/ directory? >>>> >>> >>> Greg, what is the path name convention for adding a driver to staging >>> when its eventual destination is part of a subsystem? Perhaps it >>> should be drivers/staging/hw/hfi1? >> >> As I have no idea what this driver is, or what it is for, > > It’s a driver for Intel’s newest RDMA capable fabric interface. It’s not InfiniBand, but Intel’s answer to InfiniBand and will eventually live in the drivers/infiniband/hw tree with the other RDMA capable device drivers. Apparently it also needs to depend on INFINIBAND: (from today's linux-next) drivers/built-in.o: In function `ipath_remove_one': ipath_driver.c:(.text+0x7591cb): undefined reference to `ib_wq' drivers/built-in.o: In function `handle_e_ibstatuschanged.isra.10': ipath_intr.c:(.text+0x768e13): undefined reference to `ib_dispatch_event' ipath_intr.c:(.text+0x768ee7): undefined reference to `ib_dispatch_event' ipath_intr.c:(.text+0x768f4b): undefined reference to `ib_dispatch_event' drivers/built-in.o: In function `signal_ib_event': (.text+0x76af44): undefined reference to `ib_dispatch_event' drivers/built-in.o: In function `ipath_process_mad': (.text+0x76e684): undefined reference to `ib_dispatch_event' drivers/built-in.o:(.text+0x76ee0b): more undefined references to `ib_dispatch_event' follow drivers/built-in.o: In function `ipath_modify_qp': (.text+0x770bb1): undefined reference to `ib_modify_qp_is_ok' drivers/built-in.o: In function `ipath_release_user_pages_on_close': (.text+0x782900): undefined reference to `ib_wq' drivers/built-in.o: In function `ipath_register_ib_device': (.text+0x788fcf): undefined reference to `ib_alloc_device' drivers/built-in.o: In function `ipath_register_ib_device': (.text+0x789063): undefined reference to `ib_dealloc_device' drivers/built-in.o: In function `ipath_register_ib_device': (.text+0x78971d): undefined reference to `ib_register_device' drivers/built-in.o: In function `ipath_register_ib_device': (.text+0x789921): undefined reference to `ib_unregister_device' drivers/built-in.o: In function `ipath_unregister_ib_device': (.text+0x7899b2): undefined reference to `ib_unregister_device' drivers/built-in.o: In function `ipath_unregister_ib_device': (.text+0x789cc7): undefined reference to `ib_dealloc_device' drivers/built-in.o: In function `set_link_state': (.text+0x79aca2): undefined reference to `ib_dispatch_event' drivers/built-in.o: In function `hfi1_free_devdata': (.text+0x7b2a54): undefined reference to `ib_dealloc_device' drivers/built-in.o: In function `remove_one': init.c:(.text+0x7b2ec0): undefined reference to `ib_wq' drivers/built-in.o: In function `hfi1_alloc_devdata': (.text+0x7b2f20): undefined reference to `ib_alloc_device' drivers/built-in.o: In function `hfi1_alloc_devdata': (.text+0x7b307b): undefined reference to `ib_dealloc_device' drivers/built-in.o: In function `init_one': init.c:(.text+0x7b49af): undefined reference to `ib_wq' drivers/built-in.o: In function `handle_linkup_change': (.text+0x7b4da1): undefined reference to `ib_dispatch_event' drivers/built-in.o: In function `send_handler': mad.c:(.text+0x7b5f3d): undefined reference to `ib_free_send_mad' drivers/built-in.o: In function `send_trap.constprop.29': mad.c:(.text+0x7b76ab): undefined reference to `ib_create_send_mad' mad.c:(.text+0x7b77d0): undefined reference to `ib_free_send_mad' mad.c:(.text+0x7b77fe): undefined reference to `ib_post_send_mad' drivers/built-in.o: In function `subn_set_opa_sma': mad.c:(.text+0x7bad4f): undefined reference to `ib_dispatch_event' mad.c:(.text+0x7baf72): undefined reference to `ib_dispatch_event' mad.c:(.text+0x7bc016): undefined reference to `ib_dispatch_event' mad.c:(.text+0x7bc062): undefined reference to `ib_dispatch_event' drivers/built-in.o: In function `hfi1_create_agents': (.text+0x7beb07): undefined reference to `ib_register_mad_agent' drivers/built-in.o: In function `hfi1_create_agents': (.text+0x7beb9d): undefined reference to `ib_unregister_mad_agent' drivers/built-in.o: In function `hfi1_free_agents': (.text+0x7bec6a): undefined reference to `ib_unregister_mad_agent' drivers/built-in.o: In function `hfi1_free_agents': (.text+0x7bec71): undefined reference to `ib_destroy_ah' drivers/built-in.o: In function `hfi1_modify_qp': (.text+0x7c7446): undefined reference to `ib_modify_qp_is_ok' drivers/built-in.o: In function `hfi1_modify_qp': (.text+0x7c7c47): undefined reference to `ib_rate_to_mbps' drivers/built-in.o: In function `hfi1_make_ud_req': (.text+0x7e9311): undefined reference to `ib_rate_to_mbps' drivers/built-in.o: In function `hfi1_check_ah': (.text+0x7f3e55): undefined reference to `ib_rate_to_mbps' drivers/built-in.o: In function `hfi1_create_qp0_ah': (.text+0x7f43d4): undefined reference to `ib_create_ah' drivers/built-in.o: In function `hfi1_register_ib_device': (.text+0x7f4bbe): undefined reference to `ib_register_device' drivers/built-in.o: In function `hfi1_register_ib_device': (.text+0x7f4d0e): undefined reference to `ib_unregister_device' drivers/built-in.o: In function `hfi1_unregister_ib_device': (.text+0x7f4d4e): undefined reference to `ib_unregister_device' -- ~Randy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
