Re: [PATCH] Kconfig: add temporary PCI dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Aug 18, 2015, at 9:50 AM, Greg KH <greg@xxxxxxxxx> wrote:
> 
> On Tue, Aug 18, 2015 at 04:29:50PM +0000, Marciniszyn, Mike wrote:
>>> Subject: Re: [PATCH] Kconfig: add temporary PCI dependency
>>> 
>>> On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote:
>>>> The move from infiniband to staging requires a temporary PCI
>>>> dependency to fix 0-day build issues.  The
>>>> drivers/infiniband/hw/Kconfig gratuitously added it for all drivers.
>>>> 
>>>> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>
>>>> ---
>>>> drivers/staging/hfi1/Kconfig |    2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> Why are these drivers not in drivers/staging/infiniband/ ?  Why do they all
>>> need their own drivers/staging/ directory?
>>> 
>> 
>> Greg, what is the path name convention for adding a driver to staging
>> when its eventual destination is part of a subsystem?  Perhaps it
>> should be drivers/staging/hw/hfi1?
> 
> As I have no idea what this driver is, or what it is for,

It’s a driver for Intel’s newest RDMA capable fabric interface.  It’s not InfiniBand, but Intel’s answer to InfiniBand and will eventually live in the drivers/infiniband/hw tree with the other RDMA capable device drivers.

> or why it is
> in staging, I can't answer this…

I put it in staging in my tree because it’s >50,000 lines of code, so repeated patch submissions to the mailing list were absolutely painful, but it has work that needs done as a result of review comments, and one item of work in particular (converting it to use an RDMA transfer engine library) will take a lot of work, so putting it in staging and requiring that to be complete before putting it in the regular tree is a decent carrot for getting that large bit of work done.

—
Doug Ledford <dledford@xxxxxxxxxx>
	GPG Key ID: 0E572FDD





Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux