On Tue, Aug 18, 2015 at 01:38:21AM -0400, Raphaël Beamonte wrote: > 2015-08-18 1:02 GMT-04:00 Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>: > > since you are modifying these lines for consistent spacing, it will be > > better to have: > > (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit > <snip> > > This should be: > > priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >> 8; > > Are you talking about spacing around the << and >> ? > If so, shouldn't that last line be: > priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID >> 1)) >> 8; yeah.. I missed that >>1 , i only noticed >>8 as you have changed that. > > And should I thus apply that to the whole file? I think that will be better, since you are sending the patch for consistent spacing. And some of your patches are not having any commit message. Greg will not accept such patches. So while you are sending take care of that also. regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
