2015-08-18 1:02 GMT-04:00 Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>: > since you are modifying these lines for consistent spacing, it will be > better to have: > (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit <snip> > This should be: > priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >> 8; Are you talking about spacing around the << and >> ? If so, shouldn't that last line be: priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID >> 1)) >> 8; And should I thus apply that to the whole file? Thanks! Raphaël _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
