On Mon, Aug 03, 2015 at 11:17:06AM +0530, Shraddha Barke wrote:
> Declare the file_operations structure ll_file_operations as const, as done
> elsewhere in the kernel, as there are no modifications to its fields.
>
> Problem found using checkpatch:
>
> WARNING: struct file_operations should normally be const
>
> Signed-off-by: Shraddha Barke <shraddha.6596@xxxxxxxxx>
> ---
You have not even build tested your patch before sending. :(
drivers/staging/lustre/lustre/llite/file.c:3119:30: error: conflicting type qualifiers for ‘ll_file_operations’
const struct file_operations ll_file_operations = {
^
In file included from drivers/staging/lustre/lustre/llite/file.c:48:0:
drivers/staging/lustre/lustre/llite/llite_internal.h:710:31: note: previous declaration of ‘ll_file_operations’ was here
extern struct file_operations ll_file_operations;
^
drivers/staging/lustre/lustre/llite/file.c:3132:30: error: conflicting type qualifiers for ‘ll_file_operations_flock’
const struct file_operations ll_file_operations_flock = {
^
In file included from drivers/staging/lustre/lustre/llite/file.c:48:0:
drivers/staging/lustre/lustre/llite/llite_internal.h:711:31: note: previous declaration of ‘ll_file_operations_flock’ was here
extern struct file_operations ll_file_operations_flock;
^
drivers/staging/lustre/lustre/llite/file.c:3148:30: error: conflicting type qualifiers for ‘ll_file_operations_noflock’
const struct file_operations ll_file_operations_noflock = {
^
In file included from drivers/staging/lustre/lustre/llite/file.c:48:0:
drivers/staging/lustre/lustre/llite/llite_internal.h:712:31: note: previous declaration of ‘ll_file_operations_noflock’ was here
extern struct file_operations ll_file_operations_noflock;
^
make[3]: *** [drivers/staging/lustre/lustre/llite/file.o] Error 1
make[2]: *** [drivers/staging/lustre/lustre/llite] Error 2
make[1]: *** [drivers/staging/lustre/lustre] Error 2
make: *** [_module_drivers/staging/lustre] Error 2
regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
