Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 03, 2015 at 09:15:56AM +0300, Dan Carpenter wrote:
> > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> I don't really feel comfortable saying I reviewed this code.  I just
> commented on a few process issues.  I don't know the subsystem well
> enough to give it a seal of approval.
> 

Biao was asking off list, how to fix this.  I guess just leave it.  I
more care about going forward that we don't start doing this all the
time.

I recently added a reviewed-by tag for someone.  He told me off list
that the patch "looks OK".  He was the subsystem expert and we were
patching his code so it was his responsibility to review the fix.  If
the patch breaks everyone's system then he's absolutely the guy that I
want people to blame.  :)

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux